Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hover animation on preview frame for classic themes #68976

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Disable hover animation on preview frame for classic themes #68976

merged 2 commits into from
Feb 3, 2025

Conversation

singhakanshu00
Copy link
Contributor

What?

closes #68948

Why?

  • There is a zoom effect or hover on classic theme preview, which is unwanted.

How?

  • Added an extra parameter to ResizableFrame component to disable the zoom and can be passed from where the component is rendered.

Testing Instructions

  1. Activate a classic theme with the theme support for editor-styles
  2. Navigate to Design
  3. Hover on the theme preview, the zoom effect is disabled.

Screenshots or screencast

Before:

Screen.Recording.2025-01-31.at.12.57.59.PM.mov

After:

Screen.Recording.2025-01-31.at.12.58.31.PM.mov

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 31, 2025
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @singhakanshu00! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@singhakanshu00 singhakanshu00 marked this pull request as ready for review January 31, 2025 07:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: singhakanshu00 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: stokesman <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think this PR will disable zoom not only in classic theme but also in block theme.

@carolinan @stokesman What is expected here is to disable zoom only in classic theme, right?

If so, I think we can reuse isBlockTheme here without introducing a new prop to ResizableFrame component.

@carolinan
Copy link
Contributor

@carolinan @stokesman What is expected here is to disable zoom only in classic theme, right?

Yes

@singhakanshu00
Copy link
Contributor Author

Thanks @t-hamano for the input.

Modified the changes in the recent commit.

@stokesman stokesman added the [Type] Enhancement A suggestion for improvement. label Feb 3, 2025
@stokesman stokesman changed the title feat: Adds an extra parameter to ResizableFrame to disable zoom Disable hover animation on preview frame for classic themes Feb 3, 2025
stokesman
stokesman approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@stokesman stokesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. Thank you 🙇

@stokesman
Copy link
Contributor

Noting that removing the hover animation for classic themes was considered ideal #66851 (comment) in the very PR that brought the preview to classic themes—I'm merging it.

@stokesman stokesman merged commit ae20971 into WordPress:trunk Feb 3, 2025
66 of 67 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.3 milestone Feb 3, 2025
@carolinan
Copy link
Contributor

nice, I missed that comment.

Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
@singhakanshu00 @t-hamano
@carolinan @stokesman @Kallyan01
Disable hover animation on preview frame for classic themes (WordPres…
991cc2c 
…s#68976)

Co-authored-by: singhakanshu00 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: stokesman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stokesman stokesman stokesman approved these changes

@t-hamano t-hamano Awaiting requested review from t-hamano

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.3
Development

Successfully merging this pull request may close these issues.

Disable the zoom on the classic theme preview under Appearance > Design
4 participants
@singhakanshu00 @carolinan @stokesman @t-hamano